dws-jobtap: avoid setting aux too early #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: as described in #285, the
dws-jobtap
plugin creates a boolean jobtap aux to indicate whether or not the prolog it sets on jobs is still active, but it creates the aux in the DEPEND state despite the fact that it will not start the prolog until the RUN state. If Flux is restarted with jobs in the queue, the aux will be lost and a lookup for the aux will cause the RUN callback to fail.Only set the
prolog_active
aux at the time that the prolog is actually started, and not before.Fixes #285.